Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(versioning): add PVP versioning scheme #32298

Merged
merged 16 commits into from
Dec 6, 2024

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Nov 4, 2024

Changes

This initial version of PVP versioning only supports Cabal ranges with form

>=X.Y && <V.W

Follow up PRs will add support for datasource, manager,
and possibly more range forms.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

Since these changes are not user facing (yet), I am not editing documentation yet.

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Since upcoming PRs will add datasource/manager, we can test on real repos then.

@secustor secustor self-requested a review November 6, 2024 09:31
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part

lib/modules/versioning/pvp/index.spec.ts Show resolved Hide resolved
lib/modules/versioning/pvp/readme.md Show resolved Hide resolved
lib/modules/versioning/pvp/index.spec.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
@ysangkok
Copy link
Contributor Author

ysangkok commented Nov 9, 2024

Thanks for the review, I believe I have addressed your comments. Please let me know if something is missing.

@secustor secustor self-requested a review November 12, 2024 08:04
lib/modules/versioning/pvp/index.spec.ts Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/readme.md Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from secustor November 18, 2024 06:11
@viceice viceice self-requested a review November 18, 2024 17:47
lib/modules/versioning/pvp/types.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/index.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice November 20, 2024 12:26
lib/modules/versioning/pvp/range.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/util.ts Outdated Show resolved Hide resolved
lib/modules/versioning/pvp/util.ts Outdated Show resolved Hide resolved
@ysangkok ysangkok requested a review from viceice November 22, 2024 21:20
@ysangkok
Copy link
Contributor Author

ysangkok commented Dec 4, 2024

I have addressed all outstanding requests, please let me know if there is anything else I can do to advance this!

@rarkins rarkins enabled auto-merge December 5, 2024 14:23
@rarkins rarkins added this pull request to the merge queue Dec 6, 2024
Merged via the queue into renovatebot:main with commit 2f805f4 Dec 6, 2024
39 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 39.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ysangkok ysangkok deleted the haskell-versioning-basic branch December 6, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants